Skip to content

refactor(ci/cd): update P0 bot to use priority: critical label#2149

Merged
exploreriii merged 4 commits into
hiero-ledger:mainfrom
tannaya7:clean-priority-critical-fix
Apr 20, 2026
Merged

refactor(ci/cd): update P0 bot to use priority: critical label#2149
exploreriii merged 4 commits into
hiero-ledger:mainfrom
tannaya7:clean-priority-critical-fix

Conversation

@tannaya7

@tannaya7 tannaya7 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Description:
Update the P0 notification bot and workflow to use the priority: critical label instead of p0.

  • Add CRITICAL_LABEL constant in the bot script
  • Replace inline p0 label checks with CRITICAL_LABEL.toLowerCase()
  • Update notification text to refer to a "critical priority issue"
  • Update GitHub Actions workflow to trigger on priority: critical and Priority: Critical

Related issue(s):

Fixes #2127

Notes for reviewer:

  • Existing HTML marker comment (<!-- P0 Issue Notification -->) is intentionally left unchanged to preserve deduplication logic
  • Changes are limited to bot script and workflow only

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@tannaya7
tannaya7 requested review from a team as code owners April 15, 2026 17:51
@coderabbitai

coderabbitai Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The notification bot and its workflow were updated to use the label priority: critical (case-insensitive) instead of p0. The script's label checks, notification text, and a notifyTeam function declaration were refactored; the workflow condition was adjusted to match the new label name.

Changes

Cohort / File(s) Summary
Workflow Configuration
\.github/workflows/bot-p0-issues-notify-team.yml		 Changed job/if condition to detect priority: critical (case-insensitive) labels instead of p0/P0. Minor whitespace/formatting tweak in the inline script invocation.
Bot Script Logic
\.github/scripts/bot-p0-issues-notify-team.js		 Introduced CRITICAL_LABEL = 'priority: critical'; replaced prior p0 checks with case-insensitive comparisons to CRITICAL_LABEL; sanitized issue title for notifications; refactored notifyTeam into a top-level async function; adjusted notification message to say "critical priority".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: refactoring the CI/CD bot to use the 'priority: critical' label instead of 'p0', which directly matches the primary objective of the pull request.
Description check ✅ Passed The description is well-related to the changeset, explaining the update from 'p0' to 'priority: critical' label, including specific implementation details and linking to the related issue #2127.
Linked Issues check ✅ Passed The PR successfully implements all core coding requirements from issue #2127: replaces 'p0' label with 'priority: critical' in both the bot script and workflow, updates notification text, and keeps changes minimal and scoped [#2127].
Out of Scope Changes check ✅ Passed All changes are within scope and limited to the bot script and workflow files as specified in issue #2127. No unrelated modifications to other files or unexpected changes are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📋 Issue Planner

Built with CodeRabbit's Coding Plans for faster development and fewer bugs.

View plan used: #2127

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production

codacy-production Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@manishdait

manishdait commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

@tannaya7, your commit is missing the signoff you can fix it by running

git rebase -i HEAD~1
git commit --amend --no-edit -s -S

manishdait
manishdait reviewed Apr 15, 2026
View reviewed changes
Comment thread .github/workflows/bot-p0-issues-notify-team.yml Outdated
exploreriii
exploreriii requested changes Apr 16, 2026
View reviewed changes

@exploreriii exploreriii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tannaya7 your signing is not passing DCO checks, please resign your commits following the guide in the issue body.
Also Manish is requesting chagnes - thanks!

@exploreriii
exploreriii marked this pull request as draft April 16, 2026 14:39
exploreriii
exploreriii reviewed Apr 16, 2026
View reviewed changes
Comment thread .github/scripts/bot-p0-issues-notify-team.js Outdated
@tannaya7
tannaya7 force-pushed the clean-priority-critical-fix branch 2 times, most recently from 4bebe0b to 5b3a094 Compare April 16, 2026 17:19
@tannaya7
tannaya7 marked this pull request as ready for review April 16, 2026 17:20
coderabbitai[bot]
coderabbitai Bot reviewed Apr 16, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b5ad3ab9-7bdb-41da-83a8-4a15d3668d45

📥 Commits

Reviewing files that changed from the base of the PR and between 93a8f44 and 413018a.

📒 Files selected for processing (2)
  • .github/scripts/bot-p0-issues-notify-team.js
  • .github/workflows/bot-p0-issues-notify-team.yml

Comment thread .github/scripts/bot-p0-issues-notify-team.js Outdated
@tannaya7
refactor(ci/cd): update P0 bot to use priority: critical label
6915b48 
Signed-off-by: tannaya7 <tannayasupriya157@gmail.com>
@tannaya7
tannaya7 force-pushed the clean-priority-critical-fix branch from 413018a to 6915b48 Compare April 16, 2026 17:38
@exploreriii exploreriii added step: 2nd second stage of the review approval process reviewer: write requires a review with write permissions labels Apr 16, 2026
coderabbitai[bot]
coderabbitai Bot reviewed Apr 18, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 58baf198-78d9-4c1f-ad05-b0c8ca587b47

📥 Commits

Reviewing files that changed from the base of the PR and between 413018a and fc23591.

📒 Files selected for processing (2)
  • .github/scripts/bot-p0-issues-notify-team.js
  • .github/workflows/bot-p0-issues-notify-team.yml

Comment thread .github/workflows/bot-p0-issues-notify-team.yml
manishdait
manishdait approved these changes Apr 20, 2026
View reviewed changes

@manishdait manishdait left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannaya7. Please update the branch

@github-actions github-actions Bot added skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues scope: CI/CD involves continuous integration or delivery labels Apr 20, 2026
@exploreriii
exploreriii merged commit 99fa57b into hiero-ledger:main Apr 20, 2026
11 checks passed
@exploreriii

exploreriii commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Thank you so much!

Abhijeet2409 pushed a commit to Abhijeet2409/hiero-sdk-python that referenced this pull request Apr 22, 2026
@tannaya7 @Abhijeet2409
refactor(ci/cd): update P0 bot to use priority: critical label (hiero…
17fa428 
…-ledger#2149)

Signed-off-by: tannaya7 <tannayasupriya157@gmail.com>
AntonioCeppellini pushed a commit to AntonioCeppellini/hiero-sdk-python that referenced this pull request Apr 22, 2026
@tannaya7 @AntonioCeppellini
refactor(ci/cd): update P0 bot to use priority: critical label (hiero…
a43d386 
…-ledger#2149)

Signed-off-by: tannaya7 <tannayasupriya157@gmail.com>
parvninama pushed a commit to parvninama/hiero-sdk-python that referenced this pull request Apr 25, 2026
@tannaya7 @parvninama
refactor(ci/cd): update P0 bot to use priority: critical label (hiero…
74f95a9 
…-ledger#2149)

Signed-off-by: tannaya7 <tannayasupriya157@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@manishdait manishdait manishdait approved these changes
@exploreriii exploreriii exploreriii approved these changes
@nadineloepfe nadineloepfe Awaiting requested review from nadineloepfe nadineloepfe is a code owner automatically assigned from hiero-ledger/hiero-sdk-python-maintainers
@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hiero-ledger/github-maintainers

Assignees

No one assigned

Labels

reviewer: write requires a review with write permissions scope: CI/CD involves continuous integration or delivery skill: beginner Achievable by a fairly new comer that has already completed a couple of good first issues step: 2nd second stage of the review approval process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor priority 0 bot

3 participants

@tannaya7 @manishdait @exploreriii